Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): colon when no description is present for popping columns #12981

Merged
merged 5 commits into from
Feb 4, 2025
Merged

fix(platform): colon when no description is present for popping columns #12981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7145902
fix(platform): aria-label for vhd clear button
mikerodonnell89 Jan 28, 2025
dde57ea
fix(platform): colon when no description is present for popping columns
mikerodonnell89 Jan 28, 2025
b46f11e
Merge branch 'main' into fix/12637
droshev Feb 3, 2025
a5510a3
Merge branch 'main' into fix/12637
mikerodonnell89 Feb 4, 2025
784b139
Merge branch 'main' into fix/12637
mikerodonnell89 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libs/platform/table/components/table-popping-row/table-popping-row.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
>
@for (poppingColumn of _fdpTableService.poppingColumns$(); track poppingColumn.name) {
<div fd-table-text>
<label fd-form-label>{{ poppingColumn.label }}:</label>
@if (poppingColumn?.label?.length) {
<label fd-form-label>{{ poppingColumn.label }}:</label>
}

@if (poppingColumn?.columnCellTemplate) {
<ng-template
Expand Down
2 changes: 1 addition & 1 deletion libs/platform/value-help-dialog/value-help-dialog/value-help-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
fdType="transparent"
[title]="'platformVHD.footerClearSelectedTitle' | fdTranslate"
glyph="decline"
[attr.aria-label]="'platformVHD.footerClearSelectedAriaLabel' | fdTranslate"
[ariaLabel]="'platformVHD.footerClearSelectedAriaLabel' | fdTranslate"
></button>
</div>
</div>
Expand Down