fix: (Core) add fix for incorrect Shellbar overflowed counter position #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit b04f1b2 |
mikerodonnell89
changed the title
InnaAtanasova
changed the title
InnaAtanasova
approved these changes
Jan 28, 2021
JKMarkowski
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4482
depends on SAP/fundamental-styles#2094 but contains hardcoded styling for now
The shellbar notifications, when moved into the overflow menu on small screens, were not positioned correctly. This was not known in the styles library because we had only seen it in ngx thus far. This PR fixes the positioning and adds an example
Before:
After:
