fix: (Core) remove card-footer component #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 6f13a66 |
|
Code looks good, let's see the Netlify preview and the build and will approve it. |
InnaAtanasova
approved these changes
Apr 29, 2021
|
@DeepakSap14 when you introduce Breaking changes in a PR you need to provide info in the Wiki page of how the user should handle them. For example, you can introduce |
KevinOkamoto
approved these changes
Apr 30, 2021
|
@pierrom |
|
has been verified by @pierrom and issue is closed. merging this PR. |
N1XUS
pushed a commit
that referenced
this pull request
Jun 2, 2021
* fix:remove card-footer component * removed card footer from api-file * fix travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes #5157
fixes #3929
BREAKING CHANGE:
CardFooter component has been removed.
Please provide a brief summary of this pull request.
Card should have only two areas.
Card Footer needs to be removed.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md