Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary fix for coveralls failures #538

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Feb 18, 2019

Please provide a link to the associated issue.

Please provide a brief summary of this pull request.

Fundamental-react Travis builds were failing all day due to a coveralls report error. This is a known recurring issue on their end:
lemurheavy/coveralls-public#1264

This is the same method we used to fix the failure in fundamental-react, see: SAP/fundamental-react#417

The travis build will still fail if any tests fail, but will not fail the build if the coverage cannot be reported to coveralls.

If this is a new feature, have you updated the documentation?

@jbadan jbadan requested a review from a team February 19, 2019 00:02
@jbadan jbadan merged commit a544e5a into develop Feb 19, 2019
@jbadan jbadan deleted the fix/coveralls-failure branch February 19, 2019 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants