Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepInput Validation Popover widths are off #1104

Closed
prsdthkr opened this issue Jun 23, 2020 · 0 comments · Fixed by #1105
Closed

StepInput Validation Popover widths are off #1104

prsdthkr opened this issue Jun 23, 2020 · 0 comments · Fixed by #1105

Comments

@prsdthkr
Copy link
Member

prsdthkr commented Jun 23, 2020

Description

Should the StepInput validation popovers be extending beyond the input field like this?

They should ideally either

  • Align to the input field with wrapping content
  • OR have the same width as the content

We will need to defined these styles first in fundamental-styles @SAP/fundamental-styles-core-team

image

Versions

fundamental-react: v0.11.0-rc.18


NOTE: Where applicable, please include uncropped screen captures.

DISCLAIMER:
After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.

@prsdthkr prsdthkr linked a pull request Jul 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant