-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use popper for form validation messages #1105
Conversation
Deploy preview for fundamental-react ready! Built with commit 3c17a65 |
This looks really good! Two things:
|
I believe this is consistent with previous behavior; they should only open on click. However, form validation should appear on focus as well. But a deeper dive for these components could be done in a separate PR.
✅ |
Description
FormValidationOverlay
to display validation messages. Remove direct renders ofFormMessage
, which consumes DOM spacefirstFocusIndex
prop to Popover to indicate a focusable item to focus firstAffected components with validation
Out of Scope
If a component did not already have keyboard navigation, it was not added
fixes #1095