feat: Allow a custom flip boundary container for Popover #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit a88bab1 |
skvale
commented
Jul 10, 2020
| 'babel-plugin-module-resolver', | ||
| { | ||
| alias: { | ||
| 'react-popper-2': 'react-popper' |
There was a problem hiding this comment.
I'm jumping through hoops to get the generated output to look like
var _reactPopper = require("react-popper");instead of
var _reactPopper = require("react-popper-2");and still have the examples work in storybook
jbadan
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're making it possible to define a boundary where the popover should flip within. This example the popover would flip to the left first, but since the left is outside of the boundary it considers that direction invalid.
You might notice this happening in the DatePicker story
It's shifting to the
bottom-startplacement because for a time there is no fallback placement that works. Since the bottom is off the page and there's not enough room to the top yet. I don't see a good way around this other than make the DatePicker smaller.