Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DatePicker cleanup PropTypes #1131

Merged
merged 5 commits into from
Jul 21, 2020
Merged

fix: DatePicker cleanup PropTypes #1131

merged 5 commits into from
Jul 21, 2020

Conversation

prsdthkr
Copy link
Member

@prsdthkr prsdthkr commented Jul 21, 2020 •
edited
Loading

Description

Cleanup prop type warnings

Before - Primary DatePicker Story

image

After - Primary DatePicker Story

image

@prsdthkr prsdthkr changed the title fix DatePicker proptypes fix: DatePicker proptypes Jul 21, 2020
@netlify
Copy link

netlify bot commented Jul 21, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit c4c4b09

https://deploy-preview-1131--fundamental-react.netlify.app

@prsdthkr prsdthkr changed the title fix: DatePicker proptypes fix: DatePicker cleanup PropTypes Jul 21, 2020
@prsdthkr prsdthkr marked this pull request as ready for review July 21, 2020 22:22
@prsdthkr
Copy link
Member Author

Retriggering checks

@prsdthkr prsdthkr closed this Jul 21, 2020
@prsdthkr prsdthkr reopened this Jul 21, 2020
jbadan
jbadan approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as Travis starts behaving 🚀

@prsdthkr prsdthkr merged commit 00eb0c7 into master Jul 21, 2020
@prsdthkr prsdthkr deleted the fix/datepicker-proptypes branch July 21, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prsdthkr @jbadan