fix: improve screen reader instructions for DatePicker #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 4a895e5 |
| @@ -166,6 +167,7 @@ class Calendar extends Component { | |||
|
|
|||
| this.setState({ | |||
| currentDateDisplayed: newDate, | |||
| screenReaderText: this.props.localizedText.dayInstructions, | |||
There was a problem hiding this comment.
Should this be monthInstructions and the one below be yearInstructions?
There was a problem hiding this comment.
This is upon selection, so this is when it switches back to the day view.
meganaconley
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'assertive'aria-liveregion on header, and instead use polite region for all announcements. This ensures the initially-focused date is read out and the previous/next buttons aren't unexpectedly read when opening the calendar.Testing