Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SearchInput as a functional comp with forwarded ref #1218

Merged
merged 6 commits into from
Sep 23, 2020
Merged

feat: SearchInput as a functional comp with forwarded ref #1218

merged 6 commits into from
Sep 23, 2020

Conversation

prsdthkr
Copy link
Member

@prsdthkr prsdthkr commented Sep 22, 2020 •
edited
Loading

Description

In this change, we

  • convert the SearchInput component from a class component to a functional component with forwarded reference
  • update tests and snapshots
  • add story for substring search input

fixes #956

@prsdthkr prsdthkr self-assigned this Sep 22, 2020
@netlify
Copy link

netlify bot commented Sep 22, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit 790e8cf

https://deploy-preview-1218--fundamental-react.netlify.app

@prsdthkr prsdthkr marked this pull request as ready for review September 22, 2020 21:15
@prsdthkr prsdthkr requested a review from a team September 22, 2020 22:35
jbadan
jbadan approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@prsdthkr prsdthkr merged commit 03659ff into master Sep 23, 2020
@prsdthkr prsdthkr deleted the feat/search-input-forward-ref branch September 23, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees

@prsdthkr prsdthkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SearchInput: Missing forwardRef support
2 participants
@prsdthkr @jbadan