Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow adding classes to both modal body and backdrop #824

Closed
wants to merge 5 commits into from

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Dec 20, 2019

Description

similar to #816, which was removed due to a publishing conflict.

fixes #800

jacobdevera and others added 2 commits December 17, 2019 13:56
* fix: use momentjs

* fix: next/prev handling

* feat: allow adding classes to both modal body and backdrop (#816)

BREAKING CHANGE:
* removed className prop, new className props

* chore(release): version 1.0.0-rc.0 build 3065 [ci skip]

* fix: use moment in datepicker

* fix: simplify derived state logic

* fix: simplify enabled date logic

* fix: simplify validation logic

* fix: tests

* fix: localization

* fix: increase size limit

* fix: use date objects for props

* chore: calendar stories

* chore: datepicker stories

* chore: locale

* merge

* fix: unnecessary diffs

* fix: visual regression testing
@netlify
Copy link

netlify bot commented Dec 20, 2019

Deploy preview for fundamental-react ready!

Built with commit 0fda458

https://deploy-preview-824--fundamental-react.netlify.com

@jbadan
Copy link
Contributor Author

jbadan commented Jan 2, 2020

need to remove 01a4c6c before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal does not honor provided CSS class in "className" property
3 participants