feat: remove formset component #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 24bc187 |
skvale
reviewed
Mar 25, 2020
| @@ -102,7 +102,7 @@ export const FormsComponent = () => { | |||
| is displayed below the input field.`} | |||
| title='Input Help Elements'> | |||
| <> | |||
| <FormSet> | |||
| <FormGroup> | |||
There was a problem hiding this comment.
Could these be replaced with <FormFieldSet instead of <FormGroup?
There was a problem hiding this comment.
Do they need to be a FormFieldSet?
There was a problem hiding this comment.
nope! I didn't mean to suggest they should be. I just read the PR description and saw
It was replaced by FormFieldset
So I thought I'd ask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated FormSet component. It was replaced by FormFieldset.
fixes #issueid