Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Standardize the plurality of className props and variables #954

Merged
merged 2 commits into from
Apr 2, 2020
Merged

feat: Standardize the plurality of className props and variables #954

merged 2 commits into from
Apr 2, 2020

Conversation

skvale
Copy link
Contributor

@skvale skvale commented Apr 1, 2020 •
edited
Loading

Description

actionClassNames
buttonContainerClassNames
labelClassNames
inputClassNames
listClassNames
tokenizerClassNames

vs

backdropClassName
contentClassName
inputClassName
popperClassName
tableBodyClassName
table....ClassName
referenceClassName

[BREAKING] The breaking change is the renaming of the labelClasses prop to labelClassName in Checkbox.js

These should either all be singular or all plural. I chose singular to match the existing className prop
Note that this will be a breaking change for consumers.

fixes #911

@skvale skvale self-assigned this Apr 1, 2020
@netlify
Copy link

netlify bot commented Apr 1, 2020 •
edited
Loading

Deploy preview for fundamental-react ready!

Built with commit 43679ca

https://deploy-preview-954--fundamental-react.netlify.com

@skvale skvale changed the title fix(props): Standardize the plurality of className props fix: Standardize the plurality of className props Apr 1, 2020
jbadan
jbadan approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to feat because this is a breaking change? 🚢

@skvale skvale changed the title fix: Standardize the plurality of className props feat: Standardize the plurality of className props Apr 2, 2020
@skvale skvale changed the title feat: Standardize the plurality of className props feat: Standardize the plurality of className props and variables Apr 2, 2020
@skvale skvale merged commit 2922bf3 into master Apr 2, 2020
@skvale skvale deleted the fix/standardize-class-name-prop-plurality branch April 2, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees

@skvale skvale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize additional classname prop names
3 participants
@skvale @jbadan @sam-kvale-sap