Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lib: Do not use H1 as the default header level in components. #1178

Closed
bcullman opened this issue Jan 18, 2019 · 0 comments
Closed

Lib: Do not use H1 as the default header level in components. #1178

bcullman opened this issue Jan 18, 2019 · 0 comments
Assignees
@leannerivera
Labels
Library

Comments

@bcullman
Copy link
Contributor

bcullman commented Jan 18, 2019 •
edited
Loading

looking at https://sap.github.io/fundamental/components/, some components have a <H1> tag,

  • ActionBar
  • MegaMenu
  • Menu
  • Modal
  • Panel
  • SideNavigation

From an accessibility perspective, a page should have exactly one <H1> tag on the page. Having all your examples use <H1> sets a bad precedent.

It would be preferable to use <H3> as a default in your examples, and explain in the text that H1 to H6 is supported
@bcullman bcullman mentioned this issue Jan 18, 2019
Closed
@saad-mo saad-mo changed the title Do not use H1 as the default header level in components. Lib: Do not use H1 as the default header level in components. Feb 27, 2019
@eboyer eboyer mentioned this issue Mar 14, 2019
Closed
@jbadan jbadan mentioned this issue Mar 29, 2019
Closed
@leannerivera leannerivera self-assigned this Mar 29, 2019
@leannerivera leannerivera mentioned this issue Apr 1, 2019
Merged
@droshev droshev mentioned this issue Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leannerivera leannerivera

Labels
Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcullman @saad-mo @leannerivera