Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review usage of explicit H1 in the components #1337

Closed
droshev opened this issue Mar 21, 2019 · 2 comments
Closed

review usage of explicit H1 in the components #1337

droshev opened this issue Mar 21, 2019 · 2 comments
Labels
a11y Accessibility related issues

Comments

@droshev
Copy link
Contributor

droshev commented Mar 21, 2019

Describe the bug
A clear and concise description of what the bug is.
there are a number of locations in our components where fiori fundamentals hard codes <h1>. for Accessibility (A11y) purposes, these must be configurable. Additionally, they should probably provide H3 as default, and probably should not provide H1 as a option (any page should only have a single h1)

Is this issue related to a specific component?

What version of the Fiori Fundamentals are you using?

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

What front-end framework are you implementing in, e.g., Angular, React, etc.?

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@droshev droshev added the a11y Accessibility related issues label Mar 21, 2019
@jbadan
Copy link
Contributor

jbadan commented Mar 29, 2019

Looks like this is a copy of #1178 --- currently in progress :)

@jbadan
Copy link
Contributor

jbadan commented Apr 8, 2019

fixed by #1367

@jbadan jbadan closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related issues
Projects
None yet
Development

No branches or pull requests

2 participants