-
Notifications
You must be signed in to change notification settings - Fork 56
Contribution Guidelines
Thank you for considering contributing to SAP Fiori Fundamentals. It's people like you that make this such a great tool.
If you've noticed a bug or have a question, search the issue tracker to see if someone else in the community has already created a ticket. If not, go ahead and open a new issue! Be sure to include a title and clear description, as much relevant information as possible, and a code sample or an executable test case demonstrating the expected behavior that is not occurring. See Reporting an Issue.
If this is something you think you can fix, then fork Fundamentals and create a branch with a descriptive name.
A good branch name would be (where issue #325 is the ticket you're working on):
git checkout -b feature/325-japanese-translationAt this point, you're ready to make your changes! Feel free to ask for help, everyone is a beginner at first 😸
- Develop component template and SASS as a standalone component. For new components, see Creating a New Component
- Follow development guidelines around BEM structure and SASS
- Test in multiple browsers with no CSS dependencies and with common libs like Bootstrap
Any markup or CSS changes should begin the test framework. The component test framework loads only core.scss and individual component .scss files. The HTML created here will be used on the documentation site.
- Follow Download and Installation instructions in the
README - Run
npm run playground:start - Go to localhost:3030
Read more about the
testframework and Visual Testing
If your update requires changes to the documentation. The docs CSS is compiled from the source SASS.
- Run
npm start - Go to localhost:4000
Go to GitHub and make a Pull Request :D
In the subject of the pull request, use feat: to denote an enhancement, fix: to denote a bug fix, chore: for small configuration updates or docs: for documentation updates and briefly describe the bug fix or enhancement you are contributing.
Assign the Review as SAP/fundamental-styles.
A PR can only be merged into master by a maintainer if has passed all required status checks.