Change log level for unexpected errors

SAP · Dec 7, 2021 · a1b96f1 · a1b96f1
1 parent 603a4fa
commit a1b96f1
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 27 deletions.
diff --git a/lib/fileExportReporter.js b/lib/fileExportReporter.js
@@ -69,27 +69,27 @@ const FileExportReporter = function(baseReporterDecorator, config, logger) {
  }
 
  this.onBrowserComplete = async function(browser, result) {
- log.debug("onBrowserComplete triggered.");
- if (!result || result.error || result.disconnected) {
- log.debug("skipped due to incomplete test run.");
- return;
- }
+ try {
+ log.debug("onBrowserComplete triggered.");
+ if (!result || result.error || result.disconnected) {
+ log.debug("skipped due to incomplete test run.");
+ return;
+ }
 
- if (!result.exportFiles) {
- log.debug("No export files provided");
- return;
- }
+  if (!result.exportFiles) {
+  log.debug("No export files provided");
+  return;
+  }
 
- if (!Array.isArray(result.exportFiles)) {
- log.warn("Export files must be given as an array");
- return;
- }
+  if (!Array.isArray(result.exportFiles)) {
+  log.warn("Export files must be given as an array");
+  return;
+  }
 
- let exportPath = outputDir;
- if (multiBrowsers) {
- exportPath = path.join(exportPath, escapeFileName(browser.name));
- }
- try {
+ let exportPath = outputDir;
+ if (multiBrowsers) {
+ exportPath = path.join(exportPath, escapeFileName(browser.name));
+ }
  for (const file of result.exportFiles) {
  if (typeof file.name !== "string" || typeof file.content !== "string") {
  log.warn("Invalid file object. \"name\" and \"content\" must be strings");
@@ -99,7 +99,7 @@ const FileExportReporter = function(baseReporterDecorator, config, logger) {
  await writeSingleFile(exportPath, escapeFileName(file.name), file.content);
  }
  } catch (err) {
- log.warn("An unexpected error occured while exporting files\n\t" + err.message);
+ log.error("An unexpected error occured while exporting files\n\t" + err.message);
  exitCode = 1;
  }
  reporterInProcess = false;

diff --git a/test/unit/fileExportReporter.test.js b/test/unit/fileExportReporter.test.js
@@ -15,6 +15,7 @@ describe("fileExportReporter plugin", () => {
  log = {
  info: jest.fn(),
  warn: jest.fn(),
+ error: jest.fn(),
  debug: jest.fn()
  };
  logger = {
@@ -318,16 +319,12 @@ describe("fileExportReporter plugin", () => {
  fileExportReporter.onExit(doneFunction);
  expect(doneFunction).toHaveBeenCalledTimes(0); // done-function not yet called
 
- pathJoinMock
- .mockReturnValueOnce(resolvedTestPath)
- .mockImplementationOnce(() => {
- throw new Error("errorMsg");
- });
- fsAccessMock.mockRejectedValueOnce({code: "ENOENT"});
- fsWriteFileMock.mockResolvedValueOnce();
+ fsAccessMock.mockImplementationOnce(() => {
+ throw new Error("errorMsg");
+ });
  await fileExportReporter.onBrowserComplete({}, result);
 
- expect(log.warn).toBeCalledWith("An unexpected error occured while exporting files\n\terrorMsg");
+ expect(log.error).toBeCalledWith("An unexpected error occured while exporting files\n\terrorMsg");
  expect(doneFunction).toHaveBeenCalledTimes(1);
  expect(doneFunction).toBeCalledWith(1);
  });