UI5 Tooling Middleware does not serve files when url contains a query #64
Assignees
Labels
bug
Something isn't working
Comments
matz3
added a commit
to SAP/ui5-server
that referenced
this issue
May 24, 2019
This makes all middlewares independent of the express specific `req.path` property by manually parsing the standard `req.url`. The `parseurl` library is also used within express and makes sure to not parse the same URL of a request object again by using a cache on the request object. Follow up of #184 Fixes: SAP/karma-ui5#64
3 tasks
matz3
added a commit
that referenced
this issue
May 24, 2019
matz3
added a commit
to SAP/ui5-server
that referenced
this issue
May 27, 2019
This makes all middlewares independent of the express specific `req.path` property by manually parsing the standard `req.url`. The `parseurl` library is also used within express and makes sure to not parse the same URL of a request object again by using a cache on the request object. Follow up of #184 Fixes: SAP/karma-ui5#64
matz3
added a commit
that referenced
this issue
Jun 6, 2019
matz3
added a commit
that referenced
this issue
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requesting a file with a query parameter (e.g.
/base/resources/sap-ui-core.js?foo) does not work when using the UI5 Tooling middleware.The reason for this is that the whole URL (incl. query) is passed to the UI5 Server middleware, which is trying to find the file including the query, which is not working.
This should be fixed within ui5-server by parsing the
req.url.Also, the "hacky" workaround within this plugin should be removed.
The text was updated successfully, but these errors were encountered: