Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Document UI5 Tooling custom middleware integration caveats #586

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[INTERNAL] Document UI5 Tooling custom middleware integration caveats #586

merged 1 commit into from
Jul 10, 2023

Conversation

RandomByte
Copy link
Member

JIRA: CPOUI5FOUNDATION-491
Related PR: SAP/ui5-tooling#842

@RandomByte RandomByte requested review from KlattG and matz3 July 10, 2023 12:30
@coveralls
Copy link

Coverage Status

coverage: 55.69%. remained the same when pulling 74e7221 on add-karma-middleware-notice into 688155c on main.

KlattG
KlattG approved these changes Jul 10, 2023
View reviewed changes
Copy link

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte RandomByte merged commit 7a4db11 into main Jul 10, 2023
16 checks passed
@RandomByte RandomByte deleted the add-karma-middleware-notice branch July 10, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@KlattG KlattG KlattG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RandomByte @coveralls @matz3 @KlattG