-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(feature): knowledge hub Telemetry Setup #68
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aakankshagupta1994, please see my review comments. Also, please update the ide-extension
telemetry unit tests to use the right telemetry events send from the webapp. Also, please add unit tests in the webapp to simulate clicks and check if the action is triggered.
@aakankshagupta1994: I just noticed that sonar reported a bug in the PR - https://sonarcloud.io/project/issues?id=SAP_knowledge-hub-extension&pullRequest=68&resolved=false&types=BUG |
@kranthie-sap The requested changes are added. Can you please verify? |
…wledge-hub-extension into chore/renovate/telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kranthie-sap @aakankshagupta1994
the two tracked telemetry events in this pull request are for links that are clicked and need a new redux action, so far so good. However, it is often the case that an existing redux action can be used as trigger to track telemetry data. In this case, to avoid polluting application logic with telemetry events an alternative is to add a telemetry middleware and filter/map redux actions that should be tracked.
We can discuss this along with this PR or postpone the discussion until more events are added, whatever you prefer.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all my comments. There are no open issues that I can see, from my side this is approved.
Issue
#35
#36
Description
TBI - Provide telemetry data for the tutorials and tutorial tags opened
TBI - Provide telemetry data for the blogs and tags opened
FILL IN DETAILS HERE
Checklist for Pull Requests