fix title propagation issue (#1374)

SAP · Jun 3, 2020 · 3bb18be · 3bb18be
1 parent 338548c
commit 3bb18be
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/core/src/navigation/LeftNav.html b/core/src/navigation/LeftNav.html
@@ -18,12 +18,10 @@
           {#if key === 'undefined' || key.startsWith(virtualGroupPrefix)}
           <!-- Single nodes -->
           {#each nodes as node} {#if !node.hideFromNav} {#if node.label}
-          <li
-            class="fd-nested-list__item"
-            title="{$getTranslation(node.label)}"
-          >
+          <li class="fd-nested-list__item">
             <a
               href="{getRouteLink(node)}"
+              title="{$getTranslation(node.label)}"
               class="fd-nested-list__link {node === selectedNode ? 'is-selected' : ''}"
               on:click|preventDefault="{() => handleClick(node)}"
               data-testid="{getTestId(node)}"
@@ -59,11 +57,11 @@
           <li
             class="fd-nested-list__item lui-collapsible-item"
             on:click|stopPropagation="{() => handleIconClick(nodes, event.currentTarget)}"
-            title="{$getTranslation(key)}"
             data-testid="{getTestIdForCat(nodes.metaInfo, key)}"
           >
             <a
               href="javascript:void(null)"
+              title="{$getTranslation(key)}"
               class="fd-nested-list__link has-child {isExpanded(nodes, expandedCategories) ? 'is-expanded' : ''}"
               aria-haspopup="true"
               aria-expanded="{isExpanded(nodes, expandedCategories)}"
@@ -97,6 +95,7 @@
                   class="fd-nested-list__link {node === selectedNode ? 'is-selected' : ''}"
                   on:click|preventDefault="{() => handleClick(node)}"
                   data-testid="{getTestId(node)}"
+                  title="{$getTranslation(node.label)}"
                 >
                   <span
                     class="fd-nested-list__title"
@@ -125,6 +124,7 @@
                       class="fd-nested-list__link {node === selectedNode ? 'is-selected' : ''}"
                       on:click|preventDefault="{() => handleClick(node)}"
                       data-testid="{getTestId(node)}"
+                      title="{$getTranslation(node.label)}"
                     >
                       <span
                         class="fd-nested-list__title"

diff --git a/test/e2e-test-application/src/app/overview/overview.component.html b/test/e2e-test-application/src/app/overview/overview.component.html
@@ -24,7 +24,7 @@ <h3 class="fd-panel__title">LuigiClient Features</h3>
           (click)="item.clickHandler()"
         >
           <strong>{{ item.text }}</strong>
-          >&nbsp;&ndash;&nbsp;<span>{{ item.description }}</span>
+          &nbsp;&ndash;&nbsp;<span>{{ item.description }}</span>
         </li>
       </ul>
     </div>