Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dependency alerts #1948

Closed
JohannesDoberer opened this issue Mar 24, 2021 · 5 comments · Fixed by #2158
Closed

fix dependency alerts #1948

JohannesDoberer opened this issue Mar 24, 2021 · 5 comments · Fixed by #2158
Assignees
@UlianaMunich
Labels
internal Stuff like NFRs, CI pipeline
Milestone
Sprint 20

Comments

@JohannesDoberer
Copy link
Contributor

https://github.com/SAP/luigi/security/dependabot
@JohannesDoberer JohannesDoberer added the internal Stuff like NFRs, CI pipeline label Mar 24, 2021
@JohannesDoberer JohannesDoberer added this to the Sprint 18 milestone Mar 24, 2021
@JohannesDoberer JohannesDoberer modified the milestones: Sprint 18, Sprint 19 Apr 6, 2021
@JohannesDoberer JohannesDoberer modified the milestones: Sprint 19, Sprint 20 Jun 7, 2021
@stanleychh
Copy link
Contributor

stanleychh commented Jun 11, 2021 •
edited
Loading

Noted down those alerts by path

  1. /core/examples/luigi-example-angular
    is-svg, ssri, glob-parent, normalize-url, webpack-subresource-integrity, ini, postcss (PR merged @UlianaMunich )

  2. /core/examples/luigi-example-vue (PR merged: Update devDependencies of Vue example due to github security alerts #2091 )
    trim-newlines, normalize-url, glob-parent

  3. /website/docs (Merged by @stanleychh, PR: Update devDependencies of Docs #2093)
    glob-parent, trim, highlight.js, trim-newlines, normalize-url,

  4. /website/landingpage/dev/ (PR merged @UlianaMunich )
    is-svg, serialize-javascript, normalize-url, trim-newlines, glob-parent, postcss, ws

  5. /scripts/ (PR merged @UlianaMunich )
    highlight.js, normalize-url, glob-parent, trim

  6. /core/
    normalize-url, trim-newlines, glob-parent

  7. /client/ (PR merged @UlianaMunich )
    glob-parent

  8. root Luigi
    y18n, ini, trim, yargs-parser, normalize-url, trim-newlines, glob-parent, ssri,

@stanleychh stanleychh self-assigned this Jun 11, 2021
@stanleychh
Copy link
Contributor

Note: Also try to use depcheck finding out unused dependencies.

@UlianaMunich
Copy link
Contributor

UlianaMunich commented Jun 14, 2021 •
edited
Loading

PR for Vue Example: #2091

@stanleychh stanleychh removed their assignment Jun 23, 2021
@JohannesDoberer JohannesDoberer self-assigned this Jun 25, 2021
@UlianaMunich
Copy link
Contributor

PR for AngularJS example: #2128

@UlianaMunich UlianaMunich mentioned this issue Jul 19, 2021
Merged
@UlianaMunich
Copy link
Contributor

Last PR from the list for /core and root folder: #2158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UlianaMunich UlianaMunich

Labels
internal Stuff like NFRs, CI pipeline
Projects
None yet
Milestone
Sprint 20
Development

Successfully merging a pull request may close this issue.

Update DevDependencies in root and core folder, also update major Ler… UlianaMunich/luigi
3 participants
@UlianaMunich @stanleychh @JohannesDoberer