Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devDependencies of Vue example due to github security alerts #2091

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Update devDependencies of Vue example due to github security alerts #2091

merged 3 commits into from
Jun 17, 2021

Conversation

UlianaMunich
Copy link
Contributor

@UlianaMunich UlianaMunich changed the title Update devDependencies due to github security alerts Update devDependencies of Vue example due to github security alerts Jun 14, 2021
@UlianaMunich UlianaMunich mentioned this pull request Jun 14, 2021
Closed
@UlianaMunich UlianaMunich added this to the Sprint 20 milestone Jun 14, 2021
@UlianaMunich UlianaMunich added internal Stuff like NFRs, CI pipeline security/high Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 labels Jun 14, 2021
@UlianaMunich UlianaMunich requested a review from rafalgamon as a code owner June 15, 2021 09:10
@stanleychh stanleychh self-assigned this Jun 16, 2021
stanleychh
stanleychh reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@stanleychh stanleychh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please update cli-plugin-babel to the latest version too.

core/examples/luigi-example-vue/package.json
@@ -20,17 +20,19 @@
"devDependencies": {
"@vue/cli-plugin-babel": "4.0.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@vue/cli-plugin-babel": "4.0.5",
"@vue/cli-plugin-babel": "^4.5.13",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it as 4.0.5.

@JohannesDoberer JohannesDoberer merged commit 6066844 into SAP:master Jun 17, 2021
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jun 18, 2021
@JohannesDoberer
Merge branch 'Reset-Luigi-via-core-api' of github.com:JohannesDoberer…
0525e94 
…/luigi into Reset-Luigi-via-core-api

* 'Reset-Luigi-via-core-api' of github.com:JohannesDoberer/luigi:
  Bump postcss from 7.0.17 to 7.0.36 in /website/landingpage/dev (SAP#2098)
  Update devDependencies due to github security alerts (SAP#2091)
  Make Logo and App title an anchor in Shellbar (SAP#2081)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
Update devDependencies due to github security alerts (SAP#2091)
bd43c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

Assignees

@stanleychh stanleychh

Labels
internal Stuff like NFRs, CI pipeline security/high Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0
Projects
None yet
Milestone
Sprint 20
Development

Successfully merging this pull request may close these issues.
3 participants
@UlianaMunich @stanleychh @JohannesDoberer