Bugfix/preserve view #102
Merged
Bugfix/preserve view #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added root /settings page
maxmarkus
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
pekura and
y-kkamil
as code owners
kwiatekus
suggested changes
Sep 24, 2018
core/src/App.html
Outdated
|
|
||
| const addPreserveView = (component, data, config, node) => { | ||
| if (data.params.preserveView) { | ||
| console.log('TCL: addPreserveView -> data', data, node); |
There was a problem hiding this comment.
please get rid of console logs
core/src/App.html
Outdated
| nextPath: nextPath.startsWith('/') ? nextPath : '/' + nextPath, | ||
| context: component.get().context | ||
| }); | ||
| console.log('pv', pv); |
There was a problem hiding this comment.
please get rid of console logs
kwiatekus
approved these changes
Sep 25, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Refactored preserve view to be able to route to everywhere and back, added root /settings page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored preserve view to be able to route to non-child routes and back.
Fixes #97