Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for examples + consolidate filenames #1099

Merged
merged 25 commits into from
Mar 4, 2020

Conversation

alexandra-simeonova
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova commented Feb 12, 2020

Description

Changes proposed in this pull request:

  • Include example apps in documentation
  • Currently, when you install Luigi, the configuration file is created with a different name for different frameworks (basicConfiguration.js, sampleconfig.js,luigiconfig.js). Proposal: always name the file luigi-config.js. That way users can find it using search.

Related issue(s)

@maxmarkus maxmarkus self-assigned this Feb 18, 2020
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the links for the other examples that will be merged in the next days.

Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things :)

alexandra-simeonova and others added 4 commits February 25, 2020 13:08
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
alexandra-simeonova and others added 2 commits February 25, 2020 13:11
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ alexandra-simeonova
❌ maxmarkus
❌ zarkosimic
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexandra-simeonova alexandra-simeonova merged commit 514b735 into SAP:master Mar 4, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Mar 18, 2020
* master: (26 commits)
  Add implementations/scenarios (SAP#1116)
  deleteCache was missing in contextswitcher (SAP#1148)
  Update type descriptions (SAP#1131)
  Route change loses context in contextswitcher (SAP#1145)
  Debug cypress travis - parallel e2e tests (SAP#1121)
  trying to run npm step only if triggered or pushed to master (SAP#1139)
  Release v0.7.6 revert docs fiddle (SAP#1138)
  travis fix
  travis fix
  travis fix
  Release v0.7.6 fix (SAP#1137)
  Release v0.7.6 (SAP#1136)
  Refactor resolved node children data management (SAP#1119)
  Ability to update core URL without mf url change (SAP#1111)
  Add documentation search (SAP#1123)
  OIDC profile interceptor (SAP#1129)
  Added userInfo title to profile item (SAP#1115)
  Update documentation for examples + consolidate filenames (SAP#1099)
  Document how to make use of contextUpdateListener (SAP#1109)
  Document how to set auth storage type (SAP#1096)
  ...

# Conflicts:
#	.travis.yml
#	client/luigi-client.d.ts
#	client/package-lock.json
#	client/package.json
#	client/public/package.json
#	core/examples/luigi-sample-angular/src/assets/sampleexternal.html
#	core/package-lock.json
#	core/package.json
#	core/public/package.json
#	core/src/core-api/_internalLinkManager.js
#	core/src/core-api/baseClass.js
#	core/src/main.js
#	core/src/navigation/TopNav.html
#	docs/application-setup.md
#	docs/getting-started.md
#	docs/luigi-client-api.md
#	lerna.json
#	plugins/auth/src/auth-oidc/index.js
#	scripts/setup/angular.sh
#	scripts/setup/no-framework.sh
#	scripts/setup/openui5.sh
#	scripts/setup/vue.sh
#	test/e2e-test-application/e2e/tests/navigation.spec.js
#	test/e2e-test-application/package.json
#	test/e2e-test-application/src/app/project/dynamic/dynamic.component.ts
#	test/e2e-test-application/src/luigi-config/extended/auth.js
#	website/fiddle/package.json
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* consolidating filenames examples and folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants