Add hint to core functionality called early #1130
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
ndricimrr
changed the title
maxmarkus
approved these changes
Mar 11, 2020
alexandra-simeonova
approved these changes
Mar 16, 2020
maxmarkus
reviewed
Mar 17, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Mar 19, 2020
* master: Add hint to core functionality called early (SAP#1130)
JohannesDoberer
added a commit
that referenced
this pull request
Mar 25, 2020
* master: (37 commits) Update deps to 0.7.7 (#1193) Document potential wrong-usage of context/dynamic nodes (#1155) travis fix version upate to v0.7.7 (#1186) Revert fallbackFrame okResponseHandler (#1183) fix virtualTree to not add trailing slash at viewUrl (#1172) Fix navigate ok check (#1179) remove docsearch (#1178) Recalculation after cache deletion (#1173) Luigi Videos (#1060) Add hint to core functionality called early (#1130) Add implementations/scenarios (#1116) deleteCache was missing in contextswitcher (#1148) Update type descriptions (#1131) Route change loses context in contextswitcher (#1145) Debug cypress travis - parallel e2e tests (#1121) trying to run npm step only if triggered or pushed to master (#1139) Release v0.7.6 revert docs fiddle (#1138) travis fix travis fix ... # Conflicts: # .travis.yml # CHANGELOG.md # client/luigi-client.d.ts # client/package-lock.json # client/package.json # client/public/package.json # client/src/linkManager.js # core/examples/luigi-sample-angular/src/assets/sampleexternal.html # core/package-lock.json # core/package.json # core/public/package.json # core/src/core-api/_internalLinkManager.js # core/src/core-api/baseClass.js # core/src/main.js # core/src/navigation/TopNav.html # docs/application-setup.md # docs/getting-started.md # docs/luigi-client-api.md # lerna.json # plugins/auth/src/auth-oidc/index.js # scripts/setup/angular.sh # scripts/setup/no-framework.sh # scripts/setup/openui5.sh # scripts/setup/vue.sh # test/e2e-test-application/e2e/tests/1-angular/navigation.spec.js # test/e2e-test-application/package-lock.json # test/e2e-test-application/package.json # test/e2e-test-application/src/app/project/dynamic/dynamic.component.ts # test/e2e-test-application/src/luigi-config/extended/auth.js # website/docs/package-lock.json # website/docs/package.json # website/fiddle/package.json
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 14, 2020
* master: Release v1 (SAP#1201) Update deps to 0.7.7 (SAP#1193) Document potential wrong-usage of context/dynamic nodes (SAP#1155) travis fix version upate to v0.7.7 (SAP#1186) Revert fallbackFrame okResponseHandler (SAP#1183) fix virtualTree to not add trailing slash at viewUrl (SAP#1172) Fix navigate ok check (SAP#1179) remove docsearch (SAP#1178) Recalculation after cache deletion (SAP#1173) Luigi Videos (SAP#1060) Add hint to core functionality called early (SAP#1130) Add implementations/scenarios (SAP#1116) deleteCache was missing in contextswitcher (SAP#1148) Update type descriptions (SAP#1131) Route change loses context in contextswitcher (SAP#1145) Debug cypress travis - parallel e2e tests (SAP#1121)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certain Luigi functionality ( ex: auth() ) requires Luigi to be initialised, yet setConfig() might take some time causing such functionality to be called too early.
Changes proposed in this pull request:
In order to simulate the behaviour:
Add the following line :
Luigi.auth().store.getAuthData()into luigi-sample-angular/src/luigi-config/extended/main.js right after
setConfig()is called.Then wrap the setConfig call with the timeout fn:
setTimeout( ()=>{ setConfig(...); }, 0);in order to force setConfig() to lose the race. This is then going to produce a console warning
Related issue(s)