Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation node as a link to an external page #121

Merged
merged 14 commits into from
Oct 17, 2018
Merged

Navigation node as a link to an external page #121

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7dfb079
Implement externalLink nodes
parostatkiem-zz Oct 2, 2018
6a058ca
Correct readme
parostatkiem-zz Oct 2, 2018
9cd5640
Correct the typo
parostatkiem-zz Oct 3, 2018
f99aa00
Add external links icon
parostatkiem-zz Oct 3, 2018
94a3204
Improve route click handling
parostatkiem-zz Oct 3, 2018
ee2110a
Merge branch 'master' of https://github.com/kyma-project/luigi into N…
parostatkiem-zz Oct 8, 2018
f3bc754
Change externalLink to object
parostatkiem-zz Oct 8, 2018
87af131
Update readme
parostatkiem-zz Oct 8, 2018
78ae53f
Merge branch 'master' into Navigation-node-as-a-link-to-external-page
parostatkiem-zz Oct 11, 2018
4ec1923
Change overview and place of example externalUrl nodes
parostatkiem-zz Oct 11, 2018
5019860
Merge branch 'Navigation-node-as-a-link-to-external-page' of github.c…
maxmarkus Oct 16, 2018
e729bf8
fixed external link icons
maxmarkus Oct 16, 2018
41502a6
Merge remote-tracking branch 'upstream/master' into Navigation-node-a…
maxmarkus Oct 16, 2018
b99e72b
reverted backdrop changes
maxmarkus Oct 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/navigation-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ window.Luigi.setConfig({
## Nodes

- **pathSegment** specifies the partial URL of the current segment. A static settings example reflects `luigidomain.test/settings`, while a dynamic one, prefixed with a colon, loads on any other value. **pathSegments** must not contain slashes.
- **externalLinkUrl** specifies the external URL that Node leads to. If this property is set, **pathSegment** will be ignored.
- **sameWindow** defines if the external URL should be opened in new or current tab. Works only if **externalLinkUrl** is set.
- **externalLinkUrl** specifies the external URL that Node leads to. If this property is set, **pathSegment** is ignored.
- **sameWindow** defines if the external URL sis opened in a new or current tab. Works only if **externalLinkUrl** is set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sis -> is

- **label** contains the display name of the navigation Node.
- **hideFromNav** shows or hides a navigation Node. You can still navigate to the Node but it will not show up in the top or left pane.
- **viewUrl** contains the URL or path to a view that renders when entering the navigation Node. Use either a full URL or a relative path. This value may consist of variables if you have specified a **navigationContext** with a dynamic **pathSegment**. If **viewUrl** is undefined, Luigi activates the child node specified in **defaultChildNode**. When both **viewUrl** and **defaultChildNode** are undefined, Luigi opens the first child of the current node.
Expand Down