Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fromParent functionality #1222

Merged
merged 13 commits into from
Apr 8, 2020

Conversation

ndricimrr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • added fromParent functionality

example: LuigiClient.linkManager().fromParent().navigate('/sibling')

Related issue(s)

@ndricimrr ndricimrr added this to the Hardening v1.0 milestone Mar 31, 2020
@ndricimrr ndricimrr added the WIP Work in progress label Apr 1, 2020
@ndricimrr ndricimrr removed the WIP Work in progress label Apr 2, 2020
@marynaKhromova marynaKhromova self-assigned this Apr 2, 2020
@maxmarkus maxmarkus self-assigned this Apr 2, 2020
@ndricimrr ndricimrr added enhancement New feature or request documentation documentation tasks labels Apr 2, 2020
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* @since NEXTRELASE

Is missing for d.ts and jsdoc

@alexandra-simeonova alexandra-simeonova self-assigned this Apr 3, 2020
@ndricimrr ndricimrr requested a review from maxmarkus April 3, 2020 08:59
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

ndricimrr and others added 2 commits April 3, 2020 12:30
Co-Authored-By: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

ndricimrr and others added 3 commits April 6, 2020 11:14
Co-Authored-By: Markus <1720843+maxmarkus@users.noreply.github.com>
Co-Authored-By: Markus <1720843+maxmarkus@users.noreply.github.com>
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmarkus maxmarkus merged commit d6d5a52 into SAP:master Apr 8, 2020
@maxmarkus maxmarkus deleted the 1175-add-from-parent-linkmanager branch April 8, 2020 08:23
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 14, 2020
* master: (28 commits)
  Move npm and other dependencies to devDependencies in core (SAP#1252)
  release 1.0.1 (SAP#1254)
  remove outdated code (SAP#1251)
  Fix GitHub security alerts (SAP#1248)
  Release CLI (SAP#1242)
  add faq question (SAP#1238)
  upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237)
  Mixed styles of note and tip in docu (SAP#1231)
  fix svelte example (SAP#1225)
  Add fromVirtualTreeRoot to linkManager (SAP#1226)
  add fromParent functionality (SAP#1222)
  Getting notified of unresponsive Luigi clients (SAP#1159)
  Optimize documentation for disableAutoLogin (SAP#1223)
  adjust html and css in fiddle after updating Fundamental Library version (SAP#1224)
  Update screenshots in docu (SAP#1218)
  use pushState instead of location.href for oidc (SAP#1213)
  Fix duplicate login logout buttons (SAP#1220)
  Replace docsearch cdn with npm package (SAP#1198)
  Security alerts fix (SAP#1208)
  Set focus on docu search input field (SAP#1196)
  ...
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants