-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fromParent functionality #1222
add fromParent functionality #1222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @since NEXTRELASE
Is missing for d.ts and jsdoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
Co-Authored-By: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Co-Authored-By: Markus <1720843+maxmarkus@users.noreply.github.com>
Co-Authored-By: Markus <1720843+maxmarkus@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* master: (28 commits) Move npm and other dependencies to devDependencies in core (SAP#1252) release 1.0.1 (SAP#1254) remove outdated code (SAP#1251) Fix GitHub security alerts (SAP#1248) Release CLI (SAP#1242) add faq question (SAP#1238) upgrade version of fundametal library styles, include sap fonts and icons, adjust html structure for fd-menu (SAP#1237) Mixed styles of note and tip in docu (SAP#1231) fix svelte example (SAP#1225) Add fromVirtualTreeRoot to linkManager (SAP#1226) add fromParent functionality (SAP#1222) Getting notified of unresponsive Luigi clients (SAP#1159) Optimize documentation for disableAutoLogin (SAP#1223) adjust html and css in fiddle after updating Fundamental Library version (SAP#1224) Update screenshots in docu (SAP#1218) use pushState instead of location.href for oidc (SAP#1213) Fix duplicate login logout buttons (SAP#1220) Replace docsearch cdn with npm package (SAP#1198) Security alerts fix (SAP#1208) Set focus on docu search input field (SAP#1196) ...
Description
Changes proposed in this pull request:
example:
LuigiClient.linkManager().fromParent().navigate('/sibling')
Related issue(s)