Fix css issues in core and angular example #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusreal
requested review from
antiheld,
dariadomagala-sap,
hardl,
kwiatekus,
maxmarkus,
pekura and
y-kkamil
as code owners
parostatkiem-zz
suggested changes
Oct 17, 2018
parostatkiem-zz
approved these changes
Oct 17, 2018
maxmarkus
reviewed
Oct 17, 2018
| @@ -9,6 +9,7 @@ | |||
| <meta name="description" content=""> | |||
| <meta name="keywords" content="logout"> | |||
|
|
|||
| <link rel='stylesheet' href='../node_modules/fundamental-ui/dist/fundamental-ui.min.css'> | |||
There was a problem hiding this comment.
I fear this approach will not work once the user has don a npm run build and deploys the dist folder, as it will miss the fundamental-ui then?
maxmarkus
suggested changes
Oct 17, 2018
| @@ -397,6 +397,27 @@ module.exports = { | |||
| from: { | |||
| glob: 'luigi-client.js' | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
The css file is copied, but not injected into index.html
A quick tryout of webpack.config.js entry.styles: ['./src/styles.css', './node_modules/fundamental-ui/dist/fundamental-ui.min.css'] did not work in my case, needs investigation how to reference the css properly.
There was a problem hiding this comment.
Alternatively manually put it into sampleapp.html and remove the injection reference in angular.json
There was a problem hiding this comment.
fundamental-ui.min.css injected via webpack.config.js. Please check again.
…th for fundamental ui folder for external views
maxmarkus
approved these changes
Oct 18, 2018
| @@ -397,6 +397,27 @@ module.exports = { | |||
| from: { | |||
| glob: 'luigi-client.js' | |||
| } | |||
| }, | |||
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Load fundamental-ui correctly in external views on angular angular example * add missing fundamental-ui import on authorization html * Restructure markup so that logout button is displayed over iframe * Enable external views in angular example to use fundamental ui after building app * Load fundamental-ui only once in example app * In webpack config, provide app with fundamental-ui.min.css and fix path for fundamental ui folder for external views * Bring back loading indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)