Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from CLA to DCO #1538

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Switching from CLA to DCO #1538

merged 5 commits into from
Aug 11, 2020

Conversation

alexandra-simeonova
Copy link
Contributor

Description

Changes proposed in this pull request:

Related issue(s)
See also #1532

@alexandra-simeonova alexandra-simeonova added documentation documentation tasks internal Stuff like NFRs, CI pipeline labels Aug 5, 2020
@alexandra-simeonova alexandra-simeonova added this to the Sprint 12 milestone Aug 5, 2020
UlianaMunich
UlianaMunich approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and according to the guidelines

@UlianaMunich UlianaMunich self-assigned this Aug 5, 2020
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alexandra-simeonova alexandra-simeonova added WIP Work in progress and removed WIP Work in progress labels Aug 5, 2020
@JohannesDoberer JohannesDoberer self-assigned this Aug 6, 2020
@alexandra-simeonova
Copy link
Contributor Author

Issue asking for review from OSPO: https://github.wdf.sap.corp/OSPO/OSPO-request/issues/428

misappi
misappi approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@misappi misappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from my end.

misappi
misappi reviewed Aug 10, 2020
View reviewed changes
CONTRIBUTING.md
@@ -15,10 +15,8 @@ You are welcome to contribute with your pull requests. These steps explain the c
4. Make sure the tests pass.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems, that there is still mentioning of the CLA. Tis must be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

misappi
misappi requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@misappi misappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all mentions of CLA have been removed from CONTRIBUTING.md.

misappi
misappi approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@misappi misappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.

@alexandra-simeonova alexandra-simeonova merged commit 2a5fb4e into SAP:master Aug 11, 2020
@alexandra-simeonova alexandra-simeonova deleted the 1532-cla-docu branch August 11, 2020 08:26
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Aug 12, 2020
@JohannesDoberer
Merge branch 'master' into featureToggle
4fc2e9e 
* master:
  wc async loading issue (SAP#1554)
  Switching from CLA to DCO (SAP#1538)
  Update OpenUI5 Example (SAP#1541)
  Markdown plugin dev improvement (SAP#1519)
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@alexandra-simeonova
Switching from CLA to DCO (SAP#1538)
e9a5f54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@misappi misappi misappi approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@stanleychh stanleychh Awaiting requested review from stanleychh

Assignees

@UlianaMunich UlianaMunich

@JohannesDoberer JohannesDoberer

Labels
documentation documentation tasks internal Stuff like NFRs, CI pipeline
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandra-simeonova @CLAassistant @UlianaMunich @JohannesDoberer @misappi