Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e App fdstyles with v.0.11.0 #1575

Merged

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1573

Since .fd-margin-* and fd-padding-* was removed in new FD library I have replaced it with our own class which adds this margin.

Bug: Align input field and button next to it at one line

@JohannesDoberer JohannesDoberer added this to the Sprint 12 milestone Aug 19, 2020
@JohannesDoberer JohannesDoberer self-assigned this Aug 25, 2020
@ndricimrr ndricimrr self-assigned this Aug 25, 2020
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohannesDoberer JohannesDoberer modified the milestones: Sprint 12, Sprint 13 Sep 2, 2020
@UlianaMunich UlianaMunich merged commit fe2d2e7 into SAP:master Sep 3, 2020
@UlianaMunich UlianaMunich deleted the 1573-update-e2e-app-fdstyles-11.0 branch September 3, 2020 09:39
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 3, 2020
* master:
  Update fd styles core examples (SAP#1586)
  Update e2e App fdstyles with v.0.11.0 (SAP#1575)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 7, 2020
* master:
  update npm dependencies (SAP#1599)
  Possibility to set document title without Luigi header config (SAP#1591)
  Bump bl from 3.0.0 to 3.0.1 in /website/docs (SAP#1602)
  Bump bl from 3.0.0 to 3.0.1 in /core (SAP#1601)
  Update fd styles core examples (SAP#1586)
  Update e2e App fdstyles with v.0.11.0 (SAP#1575)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* update checkboxes and add margin bottom to panels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update e2e App with FD Styles 0.11.0
3 participants