New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature angular supporting library: Refactor + First Doc #1724

Merged

legteodav merged 57 commits into SAP:feature-angular-supporting-library from legteodav:feature-angular-supporting-library

Dec 3, 2020

Contributor

legteodav commented Nov 25, 2020 •

edited by ndricimrr

Loading

Removed {usage: true} in default behaviours.
Added first basic documentation on page: https://github.com/legteodav/luigi/tree/feature-angular-supporting-library/client-frameworks-support/client-support-angular/projects/client-support-angular

Fixes #1692

legteodav added 4 commits

November 24, 2020 11:56


          Removing default reuse option

a7340b9

Creating a new Standard LuigiRoute and refactor the Reuse (that it will not be used)


          Adding documentation

acb8ff7


          Adding more doc

be23978


          complete docuumetation for client-support-angular

07ddca4

legteodav requested review from alexandra-simeonova, hardl, JohannesDoberer, maxmarkus, ndricimrr, stanleychh and UlianaMunich as code owners

November 25, 2020 08:09

JohannesDoberer added this to the Sprint 14 milestone

JohannesDoberer added the enhancement label

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

legteodav and others added 3 commits

November 25, 2020 14:11


          Update client-frameworks-support/client-support-angular/projects/clie…

bdf8490

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

8b7b907

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

3d67df0

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

legteodav and others added 2 commits

November 25, 2020 15:24


          Update client-frameworks-support/client-support-angular/projects/clie…

87975ce

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

abd796c

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

UlianaMunich reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

legteodav and others added 3 commits

November 25, 2020 15:38


          Update client-frameworks-support/client-support-angular/projects/clie…

637d1da

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

8fd8030

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

cac4aff

…nt-support-angular/README.md

Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com>

legteodav and others added 6 commits

December 1, 2020 16:38


          Update client-frameworks-support/client-support-angular/projects/clie…

78ba863

…nt-support-angular/README.md

Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

3f5c31b

…nt-support-angular/README.md

Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

d7434dc

…nt-support-angular/README.md

Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>


          fixing documenttion

c840263


          more fix in documentation

5fee546


          more fix in documentation

c63b0cb

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

legteodav and others added 2 commits

December 2, 2020 09:51


          Update client-frameworks-support/client-support-angular/projects/clie…

36b003d

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>


          Update client-frameworks-support/client-support-angular/projects/clie…

a6c207a

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved


          Update client-frameworks-support/client-support-angular/projects/clie…

c2e8c13

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved


          Update client-frameworks-support/client-support-angular/projects/clie…

e82d52e

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved


          Update client-frameworks-support/client-support-angular/projects/clie…

6e92115

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved

legteodav and others added 2 commits

December 2, 2020 14:02


          Update client-frameworks-support/client-support-angular/projects/clie…

468c0a3

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>


          adding @luigi-project/client dipendency

5fe3624

ndricimrr reviewed

View reviewed changes

test/e2e-test-application/src/luigi-config/extended/globalSearch.js Outdated Show resolved Hide resolved

legteodav and others added 2 commits

December 3, 2020 10:58


          merging with SAP/eature-angular-supporting-library

7da9239


          Update test/e2e-test-application/src/luigi-config/extended/globalSear…

3bd0f15

…ch.js

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

ndricimrr reviewed

View reviewed changes

client-frameworks-support/client-support-angular/projects/client-support-angular/README.md Outdated Show resolved Hide resolved


          Update client-frameworks-support/client-support-angular/projects/clie…

cb178af

…nt-support-angular/README.md

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

ndricimrr reviewed

View reviewed changes

...ient-support-angular/projects/client-support-angular/src/lib/luigi.angular.support.module.ts Outdated Show resolved Hide resolved


          Update client-frameworks-support/client-support-angular/projects/clie…

3c27830

…nt-support-angular/src/lib/luigi.angular.support.module.ts

Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>

JohannesDoberer approved these changes

View reviewed changes

Contributor

JohannesDoberer left a comment

Works for me 👍 !

alexandra-simeonova approved these changes

View reviewed changes

legteodav merged commit 82d8e93 into SAP:feature-angular-supporting-library

maxmarkus reviewed

View reviewed changes

package.json Show resolved Hide resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

maxmarkus maxmarkus left review comments

UlianaMunich UlianaMunich left review comments

ndricimrr ndricimrr left review comments

JohannesDoberer JohannesDoberer approved these changes

alexandra-simeonova alexandra-simeonova approved these changes

hardl Awaiting requested review from hardl

stanleychh Awaiting requested review from stanleychh

Labels