Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website security #1742

Merged
merged 8 commits into from
Dec 3, 2020
Merged

Conversation

JohannesDoberer
Copy link
Contributor

Important note: rel attribute has to be in the same line as the targetattribute.
Fixes #1735

@JohannesDoberer JohannesDoberer added the security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 label Nov 30, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 14 milestone Nov 30, 2020
@JohannesDoberer JohannesDoberer added the internal Stuff like NFRs, CI pipeline label Nov 30, 2020
@UlianaMunich UlianaMunich self-assigned this Nov 30, 2020
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All the links are updated except for those which are for Blog posts. They are coming from the docu and compiled automatically, so you would need to modify the template.

  • And not related to this ticket a small bug: The link "Get started" which guides to the Docu doesn't work "https://docs.luigi-project.io/docs/application-setup.md could you please simply delete the *.md extensions from it so that it is fixed?

@JohannesDoberer
Copy link
Contributor Author

All the links are updated except for those which are for Blog posts. They are coming from the docu and compiled automatically, so you would need to modify the template.
Did you build the blogs? It is fixed in global-nav.html template.

The small bug is fixed.

@ndricimrr ndricimrr self-assigned this Dec 1, 2020
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@JohannesDoberer JohannesDoberer merged commit 8b7c493 into SAP:master Dec 3, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 3, 2020
* master:
  Feature angular supporting library (SAP#1756)
  Website security (SAP#1742)
@JohannesDoberer JohannesDoberer deleted the website-security branch December 3, 2020 20:08
JohannesDoberer added a commit that referenced this pull request Dec 8, 2020
* master:
  release-v1.7.0 (#1759)
  CM fixes (#1755)
  changes for night build (#1757)
  Feature angular supporting library (#1756)
  Website security (#1742)
  fixed case sensitivity issue in luigi element
  Feature wc support (#1751)
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 8, 2020
* feature-user-settings:
  release-v1.7.0 (SAP#1759)
  CM fixes (SAP#1755)
  changes for night build (SAP#1757)
  Feature angular supporting library (SAP#1756)
  Website security (SAP#1742)
  fixed case sensitivity issue in luigi element
  Feature wc support (SAP#1751)

# Conflicts:
#	core/package.json
#	core/src/utilities/helpers/index.js
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Stuff like NFRs, CI pipeline security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve security for website
3 participants