Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser history fix #1784

Merged
merged 8 commits into from
Dec 18, 2020
Merged

Browser history fix #1784

merged 8 commits into from
Dec 18, 2020

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Dec 14, 2020

No description provided.

@hardl hardl added this to the Sprint 15 milestone Dec 14, 2020
@hardl hardl changed the title Browser history fix (path routing) Browser history fix Dec 14, 2020
@ndricimrr ndricimrr self-assigned this Dec 15, 2020
@stanleychh stanleychh self-assigned this Dec 15, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hardl hardl merged commit ab58877 into SAP:master Dec 18, 2020
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Dec 23, 2020
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 23, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jan 7, 2021
* master:
  Release v1.7.1 (SAP#1793)
  Update example on luigi-core-api.md navigate() (SAP#1769)
  Reversed search for keepselected (SAP#1761)
  fiddle patch
  Browser history fix  (SAP#1784)
  Manage user settings (SAP#1789)
  Fix drawer undefined bug (SAP#1765)
  Fixing cypress tests for Angular Test Application (SAP#1730)
  Global search enhancements SAP#1738 (SAP#1753)

# Conflicts:
#	client/webpack.config.js
#	core/package.json
#	core/src/App.html
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
#	core/src/core-api/config.js
#	core/src/core-api/ux.js
#	core/src/utilities/constants.js
#	core/src/utilities/helpers/usersetting-dialog-helpers.js
#	docs/luigi-core-api.md
#	test/e2e-test-application/src/luigi-config/extended/projectDetailNav.js
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@hardl hardl deleted the browser-history-fix branch June 10, 2021 15:56
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants