Use Byline component for user settings dialog #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser settings window
…ser settings window html
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
legteodav,
maxmarkus,
ndricimrr and
stanleychh
as code owners
…ce working for selected item
…lianaMunich/luigi into 1921-add-byline-to-usersettings-dialog
ndricimrr
reviewed
Mar 30, 2021
ndricimrr
reviewed
Mar 30, 2021
|
Other than some small comments, LGTM 👍 |
Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
stanleychh
reviewed
Mar 30, 2021
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
stanleychh
reviewed
Mar 30, 2021
core/src/UserSettingsDialog.html
Outdated
| export function handleKeyUp(event, index) { | ||
| if ( | ||
| event.keyCode === KEYCODE_ENTER || | ||
| (KEYCODE_SPACE && event.keyCode !== KEYCODE_TAB) |
There was a problem hiding this comment.
It looks strange here. KEYCODE_SPACE is a number.
Did you mean event.keyCode === KEYCODE_SPACE ?
There was a problem hiding this comment.
thanks for pointing this out, somehow the brackets were in the wrong place. Fixed that
ndricimrr
reviewed
Mar 31, 2021
…lianaMunich/luigi into 1921-add-byline-to-usersettings-dialog
ndricimrr
approved these changes
Mar 31, 2021
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1921
Specs:
FIORI 3:https://wiki.wdf.sap.corp/wiki/display/visualcore/List+%28Fiori+3%29+-+Standard+List+with+Byline
FD Styles: https://sap.github.io/fundamental-styles/?path=/docs/components-list-byline--standard
Keyboard interaction:
https://cxwiki.sap.com/display/luigi/Fiori+Keyboard+Interaction