Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce i18n variable in viewUrl #1995

Merged
merged 6 commits into from
May 3, 2021

Conversation

stanleychh
Copy link
Contributor

@stanleychh stanleychh commented Apr 21, 2021

  • Introduce environment variables {i18n.currentLocale} which can be used in Luigi config.
  • {i18n.currentLocale} will be replaced by current locale automatically.

Fixes #1984

@stanleychh stanleychh added the documentation documentation tasks label Apr 22, 2021
@ndricimrr ndricimrr self-assigned this Apr 23, 2021
stanleychh and others added 3 commits April 28, 2021 10:07
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well👍

The original issue mentions luigi_currentLanguage , but I believe you eventually chose to go with i18n_currentLocale

@stanleychh stanleychh merged commit ef5cd02 into SAP:master May 3, 2021
@stanleychh stanleychh deleted the 1984-i18n-variable-viewurl branch May 3, 2021 08:21
@JohannesDoberer JohannesDoberer mentioned this pull request Jun 7, 2021
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
- Introduce environment variables {i18n.currentLocale} which can be used in Luigi config.
- {i18n.currentLocale} will be replaced by current locale automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks dxp enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Luigi core environment variables should be usable within the config
4 participants