Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fundamental Styles library from v0.14.0 to v0.17.0 #1996

Merged
merged 25 commits into from
May 19, 2021
Merged

Update Fundamental Styles library from v0.14.0 to v0.17.0 #1996

merged 25 commits into from
May 19, 2021

Conversation

UlianaMunich
Copy link
Contributor

Fixes #1964

While reviewing don't froget to test:

  • settings with profile picture and without
  • mobile view of dropdowns, Notifications, modals, alerts, burger etc.
  • settings for semiCollapsible mode, Fiori 3
  • Safari, Chrome, Mozilla, IE

@JohannesDoberer JohannesDoberer added this to the Sprint 19 milestone Apr 23, 2021
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Apr 23, 2021
@UlianaMunich UlianaMunich changed the title 1964 fdstyles v0.17 Update Fundamental Styles library from v0.14.0 to v0.17.0 Apr 28, 2021
@stanleychh stanleychh self-assigned this May 4, 2021
@JohannesDoberer JohannesDoberer self-assigned this May 17, 2021
JohannesDoberer
JohannesDoberer reviewed May 17, 2021
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2021-05-17 um 19 09 47
It seems there is too much space at the bottom when I use 'Fiori3' (mobile as well)

@UlianaMunich UlianaMunich merged commit 23a8e2f into SAP:master May 19, 2021
@UlianaMunich UlianaMunich deleted the 1964-fdstyles-v0.17 branch May 19, 2021 08:43
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request May 25, 2021
@JohannesDoberer
Merge branch 'master' into extend-options
6607a9a 
* master:
  fix (SAP#2043)
  Bump hosted-git-info from 2.8.4 to 2.8.9 (SAP#2018)
  Update Fundamental Styles library from v0.14.0 to v0.17.0 (SAP#1996)
  Bump lodash version of scripts/package.json (SAP#2031)
  Global nav adjustments (SAP#2035)
  Fix set document title issue when no header or title provided
  Fix misplaced content area on mobile if globalnav enabled
  Bump Fundamental Styles v0.17.0 from v0.11.0 in Fiddle (SAP#2027)
  Bump hosted-git-info from 2.8.5 to 2.8.9 in /core (SAP#2019)
  Bump url-parse in /core/examples/luigi-example-angular (SAP#2017)
  Udpdate versionc of vue-cli to 4.5.13 too fix high security ussues with sub-dependencies (SAP#2028)
@JohannesDoberer JohannesDoberer added the breaking Breaking change label Jun 7, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Jun 7, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@UlianaMunich
Update Fundamental Styles library from v0.14.0 to v0.17.0 (SAP#1996)
82cfd0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer left review comments

@stanleychh stanleychh stanleychh approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@legteodav legteodav Awaiting requested review from legteodav

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@stanleychh stanleychh

@JohannesDoberer JohannesDoberer

Labels
breaking Breaking change enhancement New feature or request
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging this pull request may close these issues.

Bump FD Styles version in Luigi Core to 0.17.0
3 participants
@UlianaMunich @stanleychh @JohannesDoberer