route null fix #2064
Merged
route null fix #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munikumar604
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
legteodav,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
|
|
JohannesDoberer
approved these changes
Jun 7, 2021
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If my child route contains children with path params and Luigi. navigation().navigate() method to navigate from child micro front end to another route in child micro frontend. Navigation js is failing due to children is null in the getChildren method of Navigation js in Luigi core.
example
navigation: { nodes: [ { pathSegment: 'admin', label: 'Admin', viewUrl: 'https://example.com/', children: [ { pathSegment: ':id', label: 'AdminID', viewUrl: 'https://example.com/:id', children: [ { pathSegment: ':selectedTab', label: 'User Profile', viewUrl: 'https://example.com/:id/:selectedTab', } ] } ] } ] } }Changes proposed in this pull request:
included null check also in getChildren method.
if (children === undefined || children === null) { children = []; }