Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path-exists fix #2065

Merged
merged 1 commit into from
May 31, 2021
Merged

path-exists fix #2065

merged 1 commit into from
May 31, 2021

Conversation

hardl
Copy link
Contributor

@hardl hardl commented May 31, 2021

When using LuigiClient.linkManager().pathExists(somePath), all linkmanager state data added to the chain has been ignored, e.g. fromParent(), fromContext(), etc.
This PR will fix this.

@hardl hardl added this to the Sprint 19 milestone May 31, 2021
ndricimrr
ndricimrr approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hardl hardl merged commit 883c392 into SAP:master May 31, 2021
@hardl hardl deleted the path-exists-fix branch May 31, 2021 17:33
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jun 1, 2021
@JohannesDoberer
Merge branch 'extend-options' of github.com:JohannesDoberer/luigi int…
37f8c18 
…o extend-options

* 'extend-options' of github.com:JohannesDoberer/luigi:
  path-exists fix (SAP#2065)
  Luigi context emulation in e2e for microfrontends (SAP#2040)
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jun 7, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Jun 7, 2021
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@hardl
path-exists fix (SAP#2065)
b7c7625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@legteodav legteodav Awaiting requested review from legteodav

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@stanleychh stanleychh Awaiting requested review from stanleychh

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging this pull request may close these issues.
3 participants
@hardl @ndricimrr @JohannesDoberer