Add newTab option to linkManager #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
rafalgamon,
stanleychh,
UlianaMunich and
wdoberschuetz
as code owners
ndricimrr
commented
Aug 12, 2021
docs/luigi-client-api.md
Outdated
Comment on lines
390
to
404
| * **since**: 0.7.7 | ||
|
|
||
| #### newTab | ||
|
|
||
| Enables navigating to a new tab. | ||
|
|
||
| ##### Examples | ||
|
|
||
| ```javascript | ||
| LuigiClient.linkManager().newTab().navigate('/projects/xy/foobar'); | ||
| ``` | ||
|
|
||
| **Meta** | ||
|
|
||
| * **since**: NEXT_RELEASE |
There was a problem hiding this comment.
- Added documentation that might need review.
ndricimrr
commented
Aug 12, 2021
Comment on lines
+1247
to
+1251
| if (e.data.params.newTab) { | ||
| let path = buildPath(e.data.params); | ||
| path = GenericHelpers.addLeadingSlash(path); | ||
| openViewInNewTab(path); | ||
| } else if (e.data.params.modal !== undefined) { |
There was a problem hiding this comment.
- Added if clause that checks if newTab is activated.
ndricimrr
changed the title
stanleychh
reviewed
Aug 16, 2021
stanleychh
reviewed
Aug 17, 2021
stanleychh
approved these changes
Aug 17, 2021
alexandra-simeonova
approved these changes
Aug 17, 2021
Co-authored-by: Stanley Hsu <stanleyhsu1984@gmail.com>
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Enables opening paths in a new tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #2188