Fixed visibleForFeatureToggles for Compound WebComponent #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalgamon
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
stanleychh,
UlianaMunich and
wdoberschuetz
as code owners
test/e2e-test-application/src/luigi-config/extended/settings.js
Outdated
Show resolved
Hide resolved
|
@rafalgamon, are you able to add few e2e test cases? That will be wonderful. |
stanleychh
suggested changes
Sep 23, 2021
… of ssh://github.com/rafalgamon/luigi into 2187-visibleForFeatureToggles-for-WebComponentCompound
stanleychh
reviewed
Oct 22, 2021
stanleychh
reviewed
Oct 28, 2021
test/e2e-test-application/e2e/tests/1-angular/luigi-client-link-manager-features.spec.js
Outdated
Show resolved
Hide resolved
stanleychh
approved these changes
Oct 28, 2021
Merged
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Fixed visibleForFeatureToggles for Compound WebComponent Co-authored-by: Uliana Caceres <2720077+UlianaMunich@users.noreply.github.com> Co-authored-by: Stanley Hsu <ching.hsiang.hsu@sap.com> Co-authored-by: JohannesDoberer <johannes.doberer@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: