Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve intent path to actual path #2286

Merged
merged 9 commits into from
Oct 8, 2021
Merged

Resolve intent path to actual path #2286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d1c6b85
Add changes
ndricimrr Sep 23, 2021
ebaa419
Merge branch 'master' into resolve-intent-path
ndricimrr Sep 23, 2021
95266c7
Merge branch 'master' into resolve-intent-path
JohannesDoberer Sep 29, 2021
6cc1bc9
Merge branch 'master' into resolve-intent-path
ndricimrr Oct 1, 2021
9749ec9
Add routing parameter check
ndricimrr Oct 7, 2021
c427c2c
Merge branch 'master' into resolve-intent-path
ndricimrr Oct 7, 2021
12fe5c8
Add documentation
ndricimrr Oct 7, 2021
095f712
Merge branch 'resolve-intent-path' of github.com:ndricimrr/luigi into…
ndricimrr Oct 7, 2021
92ab594
Merge branch 'master' into resolve-intent-path
ndricimrr Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/services/routing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,12 @@ class RoutingClass {
if (/\?intent=/i.test(window.location.hash)) {
const hash = window.location.hash.replace('#/#', '').replace('#', '');
const intentPath = RoutingHelpers.getIntentPath(hash);
// if intent faulty or illegal then skip
if (intentPath) {
// if intent faulty or illegal then skip
const isReplaceRouteActivated = Luigi.getConfigValue('routing.replaceIntentRoute');
if (isReplaceRouteActivated) {
history.replaceState(window.state, '', intentPath);
}
return intentPath;
}
}
Expand Down
7 changes: 6 additions & 1 deletion docs/navigation-parameters-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,15 @@ You can configure the way Luigi tackles routing in your application in the `rout
- **default**: `false`

### disableBrowserHistory
- **type** booean
- **type** boolean
- **description**: defines either if browser history is enabled or not.
- **default**: `false`

### replaceIntentRoute
- **type** boolean
- **description**: defines if intent navigation route resolves to actual path automatically or not.
- **default**: `false`

## Navigation parameters
The navigation parameters allow you to configure **global** navigation settings directly under the `navigation:` section in the configuration file.

Expand Down