Introduce clearNavigationCache() to clear children and titleResolver cache #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleychh
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
rafalgamon,
UlianaMunich and
wdoberschuetz
as code owners
stanleychh
changed the title
Comment on lines
+291
to
309
| clearNavigationCache() { | ||
| NodeDataManagementStorage.deleteCache(); | ||
|
|
||
| const clearTitleResolverCache = nodes => { | ||
| if (nodes && nodes.forEach) { | ||
| nodes.forEach(node => { | ||
| if (node.titleResolver && node.titleResolver._cache) { | ||
| node.titleResolver._cache = undefined; | ||
| } | ||
| if (node.children) { | ||
| clearTitleResolverCache(node.children); | ||
| } | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| clearTitleResolverCache(this.getConfig().navigation.nodes); | ||
| } | ||
| } |
There was a problem hiding this comment.
(q) We clear the cache of the nested navigation nodes - shouldn't we return a warning of some kind of any of the nodes do not meet the criteria (i.e. titleResolver doesn't exist in the node) within the ifs? I presume it makes no sense because we can only clean caches if the titleResolver already exists... but my questions stands - should we inform somehow anything/anybody that it's been cleaned or (not) cleaned? :)
wdoberschuetz
approved these changes
Nov 18, 2021
hardl
requested changes
Nov 18, 2021
hardl
approved these changes
Nov 18, 2021
Merged
stanleychh
added a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
…cache (SAP#2383) * Clear children and titleResolver cache * Update the description of clearNavigationCache()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a core API to clean nodeData cache for children resolution and titleResolver cache.
Luigi.clearNavigationCache()Related issue(s)
Fixes #2379
Draft PR: #2380