Style active node in ShellBar #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr and
stanleychh
as code owners
|
Note: This PR converted |
UlianaMunich
changed the title
…cted-node-top-nav-bug
…ich/luigi into 2460-selected-node-top-nav-bug
stanleychh
reviewed
Jan 14, 2022
core/src/navigation/TopNav.svelte
Outdated
Comment on lines
606
to
628
| <!-- {:else} | ||
| <li class="fd-menu__item"> | ||
| <a | ||
| href="{getRouteLink(node)}" | ||
| title="{getNodeLabel(node)}" | ||
| class="fd-menu__link" | ||
| on:click|preventDefault="openMobileTopNavDropDown(node)" | ||
| data-testid="mobile-topnav-dropdown-category" | ||
| > | ||
| {#if node.icon} {#if hasOpenUIicon(node)} | ||
| <span | ||
| class="fd-top-nav__icon sap-icon {getSapIconStr(node.icon)}" | ||
| ></span> | ||
| {:else} | ||
| <img | ||
| class="fd-top-nav__icon nav-icon" | ||
| src="{node.icon}" | ||
| > | ||
| {/if} {/if} | ||
| <span class="fd-list__title">{getNodeLabel(node)}</span> | ||
| </a> | ||
| </li>--> | ||
| <!-- {/if} --> |
There was a problem hiding this comment.
It seems no need to keep this part. Please remove it.
There was a problem hiding this comment.
above code does this, so I removed this commented code
JohannesDoberer
approved these changes
Jan 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2460