Keyboard accesibility for user settings dialog #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor. Rename files into svelte instead of html
UlianaMunich
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
stanleychh,
wdoberschuetz and
rafalgamon
as code owners
JohannesDoberer
requested changes
Feb 21, 2022
There was a problem hiding this comment.
It looks good. Few small things.
- Space between initials and title is too small.
- When you set
style: 'list'on type enum you will get a dropdown as well.
(In context of the e2e test app it would be "time format", see and change it tolist)
For this "kind of" dropdown the keyboard accessibility does not work. - Revert user settings configuration changes (order + custom user settings micro frontend)
test/e2e-test-application/src/luigi-config/extended/userSettings.js
Outdated
Show resolved
Hide resolved
test/e2e-test-application/src/luigi-config/extended/userSettings.js
Outdated
Show resolved
Hide resolved
…s://github.com/UlianaMunich/luigi into 2453-keyboard-interaction-user-settings-dialog
ndricimrr
approved these changes
Mar 10, 2022
JohannesDoberer
approved these changes
Mar 10, 2022
…s not reachable to use initials instead, add documentattion
…ub.com:UlianaMunich/luigi into 2453-keyboard-interaction-user-settings-dialog
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
alexandra-simeonova
approved these changes
Apr 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2453