Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple modal dialogs #2785

Merged
merged 32 commits into from
Jul 15, 2022
Merged

Multiple modal dialogs #2785

merged 32 commits into from
Jul 15, 2022

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Jun 29, 2022

Description

gif

To check:

  • ~Check goBack/hasBack functionality works with iframe ✅
  • Check goBack/hasBack functionality works with web components ⚠️
  • Check if drawer functionality affected ? ✅
  • Check A11Y not affected for both iframe and web component based modal ✅
  • Check A11Y not affected for both iframe and web component based drawer ✅
  • Check modal for web components ✅
  • check modalPathParam functionality ✅
  • add multiple modals e2e tests ✅
  • check client calls ✅
  • remove comments ✅
  • check client handshake modal-core
  • check context exchange
  • check unsaved changes ✅
  • check with full screen option ✅

Related issue(s)

Fixes #2431

@ndricimrr ndricimrr added the enhancement New feature or request label Jun 29, 2022
@ndricimrr ndricimrr changed the title 2431 multiple modal dialogs Multiple modal dialogs Jun 29, 2022
@ndricimrr ndricimrr marked this pull request as ready for review July 4, 2022 16:22
@stanleychh stanleychh self-assigned this Jul 8, 2022
@stanleychh
Copy link
Contributor

Looks good in general, well done. Only few minor suggestions.

Copy link
Contributor

@stanleychh stanleychh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ndricimrr ndricimrr merged commit 0a7ffe9 into master Jul 15, 2022
@ndricimrr ndricimrr deleted the 2431-multiple-modal-dialogs branch July 15, 2022 13:29
@JohannesDoberer JohannesDoberer mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce possibility to open multiple modal dialogs
2 participants