Add possibility to use pathRouting with angular-cli #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
parostatkiem-zz,
pekura,
tomekpapiernik and
y-kkamil
as code owners
parostatkiem-zz
suggested changes
Dec 11, 2018
jesusreal
suggested changes
Dec 11, 2018
core/examples/luigi-sample-angular/src/assets/basicConfiguration.js
Outdated
Show resolved
Hide resolved
|
e2e tets are green again, fixed a bug in LogoTitle that caused a page refresh on path routing which made the test fail. |
jesusreal
approved these changes
Dec 13, 2018
bszwarc
approved these changes
Dec 13, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* added @angular-builders to support webpack extension in angular-cli. enabled path routing for example app by default * removed obsolete webpack config and refactored e2e tests to work with path routing * fix for non-redirect issue for path routing and logo + title click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom angular-cli builder with an extra webpack config to extend angular-cli config with proper dev-server settings.
Removed startWebpack and buildWebpack command, since they are not necessary anymore.
Fixes #287 Fixes #144