-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative navigation from client does not work with dynamic nodes #362
Merged
pekura
merged 27 commits into
SAP:master
from
pekura:relative-navigation-from-client-does-not-work-with-dynamic-nodes
Jan 22, 2019
Merged
Relative navigation from client does not work with dynamic nodes #362
pekura
merged 27 commits into
SAP:master
from
pekura:relative-navigation-from-client-does-not-work-with-dynamic-nodes
Jan 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec5f47c.
y-kkamil
approved these changes
Jan 21, 2019
…ork-with-dynamic-nodes # Conflicts: # core/examples/luigi-sample-angular/src/assets/basicConfiguration.bundle.js # core/examples/luigi-sample-angular/src/assets/extendedConfiguration.bundle.js # core/examples/luigi-sample-angular/src/assets/extendedConfiguration.js
dariadomagala-sap
approved these changes
Jan 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
…#362) Relative navigation from client does not work with dynamic nodes in the parent path - fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative navigation from client does not work with dynamic nodes