Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iconClassAttribute for sap-icons #4102

Merged
merged 7 commits into from
Jan 15, 2025
Merged

iconClassAttribute for sap-icons #4102

merged 7 commits into from
Jan 15, 2025

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Jan 8, 2025 •
edited by walmazacn
Loading

Fixes #4101

@JohannesDoberer
Copy link
Contributor

For the reviewer -> Please add a cypress test

@VincentUllal VincentUllal self-assigned this Jan 9, 2025
@walmazacn walmazacn self-assigned this Jan 14, 2025
@walmazacn walmazacn marked this pull request as ready for review January 14, 2025 09:32
walmazacn
walmazacn approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both feature and test work as expected

@hardl hardl merged commit 8890887 into main Jan 15, 2025
12 checks passed
@hardl hardl deleted the fix-usersettings-iconclass branch January 15, 2025 13:58
@JohannesDoberer JohannesDoberer added bug Something isn't working ora ora related issues labels Jan 16, 2025
@JohannesDoberer JohannesDoberer mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@VincentUllal VincentUllal

@walmazacn walmazacn

Labels
bug Something isn't working ora ora related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UserSettings: iconClassAttribute not applied for SAP-icons
4 participants
@hardl @JohannesDoberer @walmazacn @VincentUllal