fix: usersettings profile entry when set in afterInit #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardl
requested review from
JohannesDoberer,
ndricimrr,
VincentUllal,
smahati,
walmazacn and
amilewskaa
as code owners
walmazacn
reviewed
Jan 15, 2025
| @@ -80,7 +80,7 @@ | |||
| const profileNavData = { | |||
| items: (await LuigiConfig.getConfigValueAsync('navigation.profile.items')) || [] | |||
| }; | |||
| if (hasUserSettings) { | |||
There was a problem hiding this comment.
If this is some issue, then can we rely on 'hasUserSettings' in the template (line 210)?
There was a problem hiding this comment.
Good point, it looks like, since the execution seems to behave 100% deterministic, but will double-check...
JohannesDoberer
approved these changes
Jan 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you set userSettings configuration in luigiAfterInit only, an error is shown in console.
This is caused by checking a state var that is changed during execution of the (async) code by the second call.